-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【WIP】feat: support built-in sql snippets #154
Open
JackWang032
wants to merge
9
commits into
DTStack:main
Choose a base branch
from
JackWang032:feat/snippets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ts失败了 |
需要等dt-sql-parser出包 |
liuxy0551
reviewed
Nov 6, 2024
@@ -80,6 +81,27 @@ export function setupLanguageFeatures( | |||
} | |||
} | |||
|
|||
function getDefaultSnippets(languageId: LanguageIdEnum) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
当前文件函数内容缩进异常
@@ -183,5 +185,17 @@ export const completionService: CompletionService = async function ( | |||
} | |||
} | |||
} | |||
return [...syntaxCompletionItems, ...keywordsCompletionItems]; | |||
|
|||
const snippetCompletionItems: ICompletionItem[] = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
当前文件缩进异常
JackWang032
force-pushed
the
feat/snippets
branch
from
November 25, 2024 10:57
0f29fa6
to
1475738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新增功能: #23 支持SQL代码片段
功能描述:对每种语言内置部分常用的SQL片段,在合适的时机可以通过关键字或者空格触发代码片段补全列表
Preview
使用方式:
默认情况下自动启用内置的代码片段,如果自定义了
completionService
, 则需要在completionService
中将snippets
返回需要手动包裹
snippets
补全项并返回设置自定义用户片段
snippets 配置参数与 vscode 的 snippet 基本相同, 详见 vscode snippets
使用
setupLanguageFeatures
方式配置的snippets
, 只有在当前输入上下文为新语句开头时才能在completionService
中访问到,如果不需要该特性, 可以直接在completionService
中使用自己的代码片段列表