Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all sql): add all sql expression column #358

Open
wants to merge 7 commits into
base: next
Choose a base branch
from

Conversation

LuckyFBB
Copy link
Collaborator

嵌套 columnName 在 expression 里面

但是有些地方使用了 expression 并不需要我们提示字段,因此我们需要判断当前 columnName 的路径是否在 groupBy 中

image

我们通过 core.collectCandidates 拿到的 candidates 就包含了当前的路径,在 ruleList 里面

  • Impala
    • select expression
    • group by expression
    • order by expression
    • partition by expression
    • having expression
    • join relation
    • case when
    • where expression
  • Trino
    • select expression
    • group by expression
    • order by expression
    • partition by expression
    • having expression
    • join relation
    • case when
    • where expression

@LuckyFBB LuckyFBB force-pushed the feat/expressionColumn branch from 7fb4c56 to 091d76d Compare October 16, 2024 02:07
@LuckyFBB LuckyFBB force-pushed the feat/expressionColumn branch 2 times, most recently from 3e250b2 to c2f525d Compare October 16, 2024 07:55
@LuckyFBB LuckyFBB force-pushed the feat/expressionColumn branch from c2f525d to 84c1008 Compare October 17, 2024 11:32
@LuckyFBB LuckyFBB changed the title feat(impala): add impala expression column feat(all sql): add impala expression column Oct 18, 2024
@LuckyFBB LuckyFBB changed the title feat(all sql): add impala expression column feat(all sql): add all sql expression column Oct 22, 2024
@mumiao
Copy link
Collaborator

mumiao commented Dec 18, 2024

  • rebase一下抵消一些变更
  • 解决一下冲突

@LuckyFBB LuckyFBB force-pushed the feat/expressionColumn branch from 427acb1 to c97ac12 Compare December 18, 2024 03:26
@LuckyFBB
Copy link
Collaborator Author

  • rebase一下抵消一些变更
  • 解决一下冲突

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants