Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a yarn clean script for the .angular/cache folder #2045

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

artlowel
Copy link
Member

Description

Since the upgrade to Angular 13 (#1567), Angular CLI persists its cache in a folder in the project root directory (more info) This improves build speeds, but can lead to hard to debug issues where old dependencies or even project code are still being used even though you've run yarn run clean, or changed that code

This PR adds the removal of that cache dir to the yarn run clean command to prevent those issues

Instructions for Reviewers

  • Check that you have an .angular/cache folder in your project root. If you don't, build the project in dev mode, and verify that you do afterwards
  • Run yarn run clean
  • Check that that cache folder is gone

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@artlowel artlowel added the 1 APPROVAL pull request only requires a single approval to merge label Jan 17, 2023
@artlowel artlowel added this to the 7.5 milestone Jan 17, 2023
@artlowel artlowel requested a review from tdonohue January 17, 2023 16:30
@artlowel artlowel self-assigned this Jan 17, 2023
@kshepherd kshepherd self-requested a review January 17, 2023 21:34
Copy link
Member

@kshepherd kshepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 thanks @artlowel , the .angular/cache folder remained after yarn run clean before applying this PR, and afterwards the cache is correctly cleaned.

@kshepherd kshepherd merged commit 105e4b6 into DSpace:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants