Upgrade to Angular 12 #1550
Closed
Upgrade to Angular 12 #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After updating to Angular 12, it causes ng serve to fail with Conflict: Multiple assets emit different content to the same filename index.html Confirmed that the application still builds and runs properly without it. This plugin isn't used by @angular-builders/custom-webpack since Angular 8 (see https://www.justjeb.com/post/customizing-angular-cli-build#viewer-51npg), this is just the first time it's actually causing problems for us. Removed script-ext-html-webpack-plugin as well since that's an extension to html-webpack-plugin & can't run without it.
Otherwise tests error out with Uncaught ReferenceError: sourceMapSupport is not defined Check just-jeb/angular-builders issue 1046 for more info
Without this, Webpack errors out when building tests due to theme components missing from the TS compilation
artlowel
added
code task
dependencies
ybnd
force-pushed
the
w2p-87968_Upgrade-to-Angular-12
branch
7 times, most recently
from
38d46af to
9bddaf6
Compare
|
Skipping ahead to Angular 13 is feasible, closing this draft in favour of #1567 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Upgrade to Angular 12
Dependencies
Major upgrades
webpackv4 → v5postcssv7 → v8@angular-builders/custom-webpackv10 → v12@ng-dynamic-formsv13 → v14A few packages don't support Angular 12 (haven't encountered any issues yet)
@kolkov/ngx-gallery(should be fine once we upgrade to Angular 13)@nicky-lenaers/ngx-scroll-tongx-sortablejsRemaining issues / TODO
bootstrapv4 → v5sass <1.33forsass-loaderto suppress a bunch of warningsds-submission-form-footerandds-claimed-task-actions-rejectCommand failed with exit code 1so it's not clear what's going wrong exactly.Reviewing
devandprodmodeChecklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
→ most of the changes in
yarn.lockyarn run lintpackage.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.