Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade generator and regenerate auto generated client for Polarion 2310 #20

Merged
merged 1 commit into from
Jan 17, 2024
Merged

feat: upgrade generator and regenerate auto generated client for Polarion 2310 #20

merged 1 commit into from
Jan 17, 2024

Conversation

micha91
Copy link
Collaborator

@micha91 micha91 commented Jan 16, 2024

  • Upgrade openapi client generator
  • Upgrade model jinja template accordingly
  • Remove unnecessary custom jinja templates
  • Execute generator for Polarion 2310
    • The specification was adjusted, because an endpoint was documented syntactically wrong
    • The body content of the importXUnitTestResults endpoint must be changed to
          "content" : {
            "application/octet-stream" : {
              "schema" : {
                "type" : "string",
                "format": "binary"
              }
            }
          }
  • Adjust the client to not be affected by breaking changes in the generator

@micha91 micha91 requested a review from ewuerger January 16, 2024 12:42
@ewuerger ewuerger mentioned this pull request Jan 16, 2024
Merged
@micha91 micha91 mentioned this pull request Jan 17, 2024
Merged
ewuerger
ewuerger requested changes Jan 17, 2024
View reviewed changes
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's only one comment.
After this: LGTM.

open_api_client_build/custom_templates/model.py.jinja Show resolved Hide resolved
open_api_client_build/custom_templates/model.py.jinja Show resolved Hide resolved
@ewuerger ewuerger self-requested a review January 17, 2024 11:20
ewuerger
ewuerger approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good argumentation. LGTM.

@micha91 micha91 merged commit 8d50bb8 into main Jan 17, 2024
6 checks passed
@ewuerger ewuerger deleted the polarion2310-upgrade branch January 17, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewuerger ewuerger ewuerger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micha91 @ewuerger