Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Documents #16

Merged
merged 8 commits into from
Jan 9, 2024
Merged

feat: Add Documents #16

merged 8 commits into from
Jan 9, 2024

Conversation

dahbar
Copy link
Contributor

@dahbar dahbar commented Dec 8, 2023 •
edited
Loading

  • Define class for Document
  • get_document()
    • Implement call
    • Tests

@dahbar dahbar force-pushed the add-documents branch 2 times, most recently from 716ee65 to 2622e9c Compare December 11, 2023 11:08
@dahbar dahbar requested a review from micha91 December 11, 2023 12:58
micha91
micha91 requested changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@micha91 micha91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some minor changes which could also be used in other parts of this project in the future
Overall a really good first PR 👍

polarion_rest_api_client/base_client.py Outdated Show resolved Hide resolved
polarion_rest_api_client/client.py Outdated Show resolved Hide resolved
polarion_rest_api_client/data_models.py Outdated Show resolved Hide resolved
micha91
micha91 requested changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@micha91 micha91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor tweaks in _handle_home_page_content and we are good to go

polarion_rest_api_client/client.py Outdated Show resolved Hide resolved
polarion_rest_api_client/client.py Outdated Show resolved Hide resolved
ewuerger
ewuerger requested changes Jan 2, 2024
View reviewed changes
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After these changes green light from me.

polarion_rest_api_client/data_models.py Outdated Show resolved Hide resolved
tests/data/mock_api_responses/get_document.json.license Show resolved Hide resolved
polarion_rest_api_client/data_models.py Outdated Show resolved Hide resolved
@dahbar dahbar changed the title Add Documents feat: Add Documents Jan 4, 2024
ewuerger
ewuerger approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ewuerger ewuerger merged commit 1aa10bd into main Jan 9, 2024
6 checks passed
@ewuerger ewuerger deleted the add-documents branch January 9, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewuerger ewuerger ewuerger approved these changes

@micha91 micha91 micha91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dahbar @micha91 @ewuerger