Upgrade to capellambse v0.6.x #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wuestengecko
force-pushed
the
capellambse-v0.6
branch
from
f4fcb7d to
2e7d4df
Compare
Wuestengecko
force-pushed
the
capellambse-v0.6
branch
from
2e7d4df to
22da27f
Compare
ewuerger
force-pushed
the
capellambse-v0.6
branch
from
22da27f to
bcb51df
Compare
Wuestengecko
force-pushed
the
capellambse-v0.6
branch
from
a71933e to
19cc001
Compare
ewuerger
force-pushed
the
capellambse-v0.6
branch
from
19cc001 to
8a3f52a
Compare
Merged
|
Was merged as part of #111, nothing more to do here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a few more type errors left, which weren't reported before because hook-mypy didn't have a capellambse installation to check against.
Interestingly I'm also getting a bunch of type errors locally that don't show up in CI. Not sure what those are about yet though (might be false-positives), I'll look into that tomorrow.
Tests are red because there's no 0.6-compatible release of context-diagrams yet. Related PR: DSD-DBS/capellambse-context-diagrams#131
Once that is merged and released, we should also explicitly set the minimum required context-diagrams version to that new release.