-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes, simplifications and improvements to logging messages #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the useless logging messages due to None type logging args. With `types.MappingProxy` we make sure that `ctx["WORK_ITEMS"]` isn't altered again. This dictionary can only be constructed as a whole.
When finding a reference to a deleted element inside a description we now ignore this uuid such that no link is tried to be created. Also strike through styling is fixed.
ewuerger
force-pushed
the
fix-descr-reference-links
branch
from
December 6, 2023 14:06
3e9176c
to
4d88d14
Compare
micha91
requested changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not end2end test it, but there are some question/proposals in the code comments. After that looking good :)
This was tested on one of our production copy projects. |
Co-authored-by: micha91 <[email protected]>
According to [py-capellambse #368](DSD-DBS/py-capellambse#368 (review)).
…a-polarion into fix-descr-reference-links
ewuerger
force-pushed
the
fix-descr-reference-links
branch
from
December 12, 2023 09:58
c82168a
to
a8f6566
Compare
ewuerger
force-pushed
the
fix-descr-reference-links
branch
from
December 12, 2023 10:00
a8f6566
to
987298f
Compare
ewuerger
force-pushed
the
fix-descr-reference-links
branch
from
December 12, 2023 13:49
136fadf
to
e638978
Compare
micha91
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.