Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes, simplifications and improvements to logging messages #28

Merged
merged 9 commits into from
Dec 12, 2023

Conversation

ewuerger
Copy link
Member

@ewuerger ewuerger commented Dec 6, 2023

No description provided.

This fixes the useless logging messages due to None type logging args.
With `types.MappingProxy` we make sure that `ctx["WORK_ITEMS"]` isn't
altered again. This dictionary can only be constructed as a whole.
When finding a reference to a deleted element inside a description we
now ignore this uuid such that no link is tried to be created.
Also strike through styling is fixed.
@ewuerger ewuerger added bug Something isn't working enhancement New feature or request labels Dec 6, 2023
@ewuerger ewuerger requested a review from micha91 December 6, 2023 13:56
@ewuerger ewuerger self-assigned this Dec 6, 2023
@ewuerger ewuerger force-pushed the fix-descr-reference-links branch from 3e9176c to 4d88d14 Compare December 6, 2023 14:06
Copy link
Collaborator

@micha91 micha91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not end2end test it, but there are some question/proposals in the code comments. After that looking good :)

capella2polarion/elements/__init__.py Outdated Show resolved Hide resolved
capella2polarion/elements/__init__.py Outdated Show resolved Hide resolved
capella2polarion/elements/__init__.py Outdated Show resolved Hide resolved
capella2polarion/elements/api_helper.py Show resolved Hide resolved
capella2polarion/elements/serialize.py Show resolved Hide resolved
@ewuerger
Copy link
Member Author

ewuerger commented Dec 7, 2023

This was tested on one of our production copy projects.

@ewuerger ewuerger force-pushed the fix-descr-reference-links branch from c82168a to a8f6566 Compare December 12, 2023 09:58
@ewuerger ewuerger force-pushed the fix-descr-reference-links branch from a8f6566 to 987298f Compare December 12, 2023 10:00
@ewuerger ewuerger force-pushed the fix-descr-reference-links branch from 136fadf to e638978 Compare December 12, 2023 13:49
@ewuerger ewuerger merged commit 6968931 into main Dec 12, 2023
5 checks passed
@ewuerger ewuerger deleted the fix-descr-reference-links branch December 12, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants