Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixed authority mode #132

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Fix mixed authority mode #132

merged 4 commits into from
Nov 21, 2024

Conversation

micha91
Copy link
Collaborator

@micha91 micha91 commented Nov 20, 2024

By now we did not check, which work items were already inserted in a mixed authority document by the user. For that reason it was possible that in the auto generated section we inserted work items, which were inserted by the user somewhere else. This causes a 4xx error when calling the REST-API as it's not allowed to insert the same work item multiple times in the same document.

@micha91 micha91 requested a review from ewuerger November 20, 2024 19:02
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only small changes. Then afterwards you get an approval.

capella2polarion/converters/document_renderer.py Outdated Show resolved Hide resolved
tests/test_documents.py Outdated Show resolved Hide resolved
tests/test_documents.py Outdated Show resolved Hide resolved
@micha91 micha91 requested a review from ewuerger November 21, 2024 09:02
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@micha91 micha91 merged commit 74dea46 into main Nov 21, 2024
9 checks passed
@micha91 micha91 deleted the fix-mixed-authority-mode branch November 21, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants