-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decrease amount of requests #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `checksum` attribute is used to filter updating work items.
This commit also simplifies the whole synchronization routine by calling less functions.
The diagram-cache index is needed when updating diagrams and model- elements is happening in the same function call.
Now diagrams are always created as Work Items and will be compared.
ewuerger
force-pushed
the
decrease-requests
branch
8 times, most recently
from
September 2, 2023 09:17
033fe96
to
da6ae58
Compare
ewuerger
force-pushed
the
decrease-requests
branch
from
September 13, 2023 11:30
3b86dbf
to
91996a4
Compare
micha91
requested changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests still need to be reviewed later
ewuerger
force-pushed
the
decrease-requests
branch
2 times, most recently
from
September 28, 2023 11:15
f2080c3
to
083065b
Compare
ewuerger
force-pushed
the
decrease-requests
branch
from
October 19, 2023 14:50
891740c
to
ece1cde
Compare
ewuerger
force-pushed
the
decrease-requests
branch
from
October 19, 2023 14:58
acad936
to
6136835
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't find anything that looks off content-wise, just a few minor style / doc comments.
This is just for the staging pipeline.
…perly for deleted references
Picked changes from b09ce59.
Co-authored-by: micha91 <[email protected]>
- Fix debug log message for empty missing types - Merge diagram work item creator into generic work item creator - Handle all roles from the wildcard entry in the config. Also include `Diagram`.
ewuerger
force-pushed
the
decrease-requests
branch
from
October 25, 2023 08:02
82ecabc
to
8a44a03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR there is only one command
model-elements
to rule them all. Diagrams and generic Capella elements are synchronized with this command. This is accomplished by refactoring and merging some functionality for diagrams into the generic work item handling. Therefore we could get rid of some stuff.