Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease amount of requests #12

Merged
merged 23 commits into from
Oct 25, 2023
Merged

Decrease amount of requests #12

merged 23 commits into from
Oct 25, 2023

Conversation

ewuerger
Copy link
Member

With this PR there is only one command model-elements to rule them all. Diagrams and generic Capella elements are synchronized with this command. This is accomplished by refactoring and merging some functionality for diagrams into the generic work item handling. Therefore we could get rid of some stuff.

ewuerger and others added 7 commits August 21, 2023 09:18
The `checksum` attribute is used to filter updating work items.
This commit also simplifies the whole synchronization routine by calling
less functions.
The diagram-cache index is needed when updating diagrams and model-
elements is happening in the same function call.
Now diagrams are always created as Work Items and will be compared.
@ewuerger ewuerger requested a review from micha91 August 31, 2023 12:53
@ewuerger ewuerger self-assigned this Aug 31, 2023
@ewuerger ewuerger force-pushed the decrease-requests branch 8 times, most recently from 033fe96 to da6ae58 Compare September 2, 2023 09:17
Copy link
Collaborator

@micha91 micha91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests still need to be reviewed later

capella2polarion/elements/serialize.py Outdated Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
capella2polarion/elements/__init__.py Outdated Show resolved Hide resolved
capella2polarion/elements/__init__.py Outdated Show resolved Hide resolved
capella2polarion/elements/__init__.py Outdated Show resolved Hide resolved
capella2polarion/elements/diagram.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
capella2polarion/elements/element.py Outdated Show resolved Hide resolved
capella2polarion/elements/element.py Outdated Show resolved Hide resolved
ci-templates/gitlab/synchronise_elements.yml Outdated Show resolved Hide resolved
@ewuerger ewuerger force-pushed the decrease-requests branch 2 times, most recently from f2080c3 to 083065b Compare September 28, 2023 11:15
@ewuerger ewuerger requested a review from Wuestengecko October 19, 2023 14:50
Copy link
Member

@Wuestengecko Wuestengecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't find anything that looks off content-wise, just a few minor style / doc comments.

capella2polarion/elements/element.py Outdated Show resolved Hide resolved
capella2polarion/elements/serialize.py Outdated Show resolved Hide resolved
capella2polarion/elements/serialize.py Outdated Show resolved Hide resolved
capella2polarion/elements/api_helper.py Outdated Show resolved Hide resolved
capella2polarion/elements/api_helper.py Outdated Show resolved Hide resolved
@ewuerger ewuerger merged commit 01c25cc into main Oct 25, 2023
5 checks passed
@ewuerger ewuerger deleted the decrease-requests branch October 25, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants