Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Keep existing rendering layouts in any case #109

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

micha91
Copy link
Collaborator

@micha91 micha91 commented Sep 5, 2024

Especially in mixed authority documents there might be work items outside the auto generated content. As these already refer a rendering layout, the order of the rendering layout must be kept as is even in the overwrite-layouts mode. Otherwise work items in non auto generated areas might use a wrong rendering layout and can look strange.

…g rendering layouts even when overwrite-layouts is enabled
@micha91 micha91 requested a review from ewuerger September 5, 2024 16:41
Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ewuerger ewuerger merged commit 2e34ce6 into main Sep 6, 2024
8 checks passed
@ewuerger ewuerger deleted the keep-layout-order-mixed-authority branch September 6, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants