Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle None return during link creation #104

Merged
merged 4 commits into from
Sep 6, 2024
Merged

fix: Handle None return during link creation #104

merged 4 commits into from
Sep 6, 2024

Conversation

ewuerger
Copy link
Member

@ewuerger ewuerger commented Aug 29, 2024 •
edited
Loading

When the value behind capella_attr is None, then we shouldn't fail with an AssertionError. Now the logs are populated.

@ewuerger ewuerger self-assigned this Aug 29, 2024
@ewuerger ewuerger requested a review from micha91 August 29, 2024 12:45
@ewuerger ewuerger force-pushed the improve-link-creation-logging branch from cde835e to 553ca1a Compare August 29, 2024 12:50
micha91
micha91 requested changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@micha91 micha91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beside these minor changes, LGTM

capella2polarion/converters/link_converter.py Outdated Show resolved Hide resolved
capella2polarion/converters/link_converter.py Outdated Show resolved Hide resolved
micha91
micha91 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@micha91 micha91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test had to be adjusted to match the new log message and level. As this wasn't possible using the request changes functionality due to existing code which had to be adjusted, I committed it on my own.
Please double check my changes, from my side LTGM

capella2polarion/converters/link_converter.py Outdated Show resolved Hide resolved
@ewuerger ewuerger force-pushed the improve-link-creation-logging branch from b2e2462 to b88231c Compare September 6, 2024 13:33
@ewuerger ewuerger merged commit 42234ef into main Sep 6, 2024
8 checks passed
@ewuerger ewuerger deleted the improve-link-creation-logging branch September 6, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micha91 micha91 micha91 approved these changes

Assignees

@ewuerger ewuerger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewuerger @micha91