Skip to content

Commit

Permalink
app/dumpcap: remove unused struct array
Browse files Browse the repository at this point in the history
[ upstream commit 9bbd44d ]

The callbacks(rx_cb) member of struct interface was unused inside
dumpcap, but was taking up a lot of memory space, since it was scaled
according to RTE_MAX_QUEUES_PER_PORT, which is 1k by default. Save
memory by removing the whole array.

Fixes: cbb4414 ("app/dumpcap: add new packet capture application")

Suggested-by: Stephen Hemminger <[email protected]>
Signed-off-by: Bruce Richardson <[email protected]>
Acked-by: Stephen Hemminger <[email protected]>
  • Loading branch information
bruce-richardson authored and kevintraynor committed Nov 7, 2024
1 parent 2751444 commit 5c3cc79
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions app/dumpcap/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ struct interface {
TAILQ_ENTRY(interface) next;
uint16_t port;
char name[RTE_ETH_NAME_MAX_LEN];

struct rte_rxtx_callback *rx_cb[RTE_MAX_QUEUES_PER_PORT];
};

TAILQ_HEAD(interface_list, interface);
Expand Down

0 comments on commit 5c3cc79

Please sign in to comment.