Subdaily EGRET plots #223
Closed
Subdaily EGRET plots #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still don't have |
R/convertToEGRET.R
Outdated
| @@ -242,7 +240,7 @@ expandFlowForEGRET <- function(flowdat, flow.colname, date.colname, flow.units) | |||
| "dateTime" = date.colname) %>% | |||
| mutate(code = "") %>% | |||
| populateDaily(qConvert = qconvert, verbose = FALSE) %>% | |||
| mutate(dateTime = flowdat[[date.colname]]) | |||
There was a problem hiding this comment.
these changes look promising!
|
I ran the two failing tests from those failing builds individually and they worked just fine...hmm. Running tests locally again. |
|
Could it be because your EGRET PR is still open? DOI-USGS/EGRET#133 |
|
Hmmm but I reverted everything except for the plot name changes. |
|
Well then, scratch that =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This in conjunction with DOI-USGS/EGRET#132