Skip to content

Commit

Permalink
updates for CRAN
Browse files Browse the repository at this point in the history
  • Loading branch information
Jordan S Read committed Oct 4, 2015
1 parent 67cead6 commit e23c43b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This is a resubmission. In this version I have:
* removed a long running web service call from the vignette,
which can sometimes fail.

* issue with no vignette index was resolved
* issue with no vignette index was resolved (see %\VignetteIndexEntry{geoknife package})

### a note about geoknife URLs:
this package has a numer of service URLs that can be found in code,
Expand Down
4 changes: 4 additions & 0 deletions tests/testthat/test-webprocess_object.R
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
context("Test create webprocess object")
test_that("creation of webprocess object", {
testthat::skip_on_cran()
expect_is(webprocess(), "webprocess")
wp <- webprocess(url = 'http://cida-test.er.usgs.gov/process/WebProcessingService')
expect_is(wp, "webprocess")
Expand All @@ -8,6 +9,7 @@ test_that("creation of webprocess object", {
context('test modifying webprocess object')

test_that("webprocess object is modified correctly", {
testthat::skip_on_cran()
wp <- webprocess(url = 'http://cida-test.er.usgs.gov/gdp/process/WebProcessingService')
# test setting url also changes util
expect_equal(slot(wp, 'UTILITY_URL'), 'http://cida-test.er.usgs.gov/gdp/utility/WebProcessingService')
Expand All @@ -18,6 +20,7 @@ test_that("webprocess object is modified correctly", {

context('test get and set webprocess object')
test_that("webprocess object get and set", {
testthat::skip_on_cran()
wp <- webprocess()
expect_is(url(wp),'character')
expect_is(version(wp), 'character')
Expand All @@ -28,6 +31,7 @@ test_that("webprocess object get and set", {

context('test pass through of webprocess')
test_that("test pass through of webprocess", {
testthat::skip_on_cran()
wp1 <- webprocess()
wp2 <- webprocess(wp1, DATASET_URI = 'www.test.com')
expect_null(inputs(wp1,'DATASET_URI')[[1]])
Expand Down

0 comments on commit e23c43b

Please sign in to comment.