Skip to content

Commit

Permalink
Merge pull request #134 from ldecicco-USGS/master
Browse files Browse the repository at this point in the history
WQP bug fix
  • Loading branch information
ldecicco-USGS committed Jul 17, 2015
2 parents ccd734a + 100e44e commit c59ec8c
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Package: dataRetrieval
Type: Package
Title: Retrieval Functions for USGS and EPA Hydrologic and Water Quality Data
Version: 2.3.0
Date: 2015-06-29
Version: 2.3.1
Date: 2015-07-17
Authors@R: c( person("Robert", "Hirsch", role = c("aut"),
email = "[email protected]"),
person("Laura", "DeCicco", role = c("aut","cre"),
Expand Down
4 changes: 2 additions & 2 deletions R/whatWQPsites.R
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ whatWQPsites <- function(...){

if (!is.na(numToBeReturned) & numToBeReturned != 0){

retval <- read.delim(textConnection(doc), header = TRUE, quote="\"",
dec=".", sep='\t',
retval <- read.delim(textConnection(doc), header = TRUE,
dec=".", sep='\t', quote="",
colClasses=c('character'),
fill = TRUE)
actualNumReturned <- nrow(retval)
Expand Down
7 changes: 4 additions & 3 deletions tests/testthat/tests_general.R
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,15 @@ test_that("General NWIS retrievals working", {

test_that("General WQP retrievals working", {
testthat::skip_on_cran()
# testthat::skip_on_cran()
# Bring back when WQP is back
nameToUse <- "pH"
pHData <- readWQPdata(siteid="USGS-04024315",characteristicName=nameToUse)
expect_is(pHData$ActivityStartDateTime, 'POSIXct')

pHDataExpanded2 <- readWQPdata(bBox=c(-90.1,42.9,-89.9,43.1),
characteristicName=nameToUse)
expect_is(pHDataExpanded2$ActivityStartDateTime, 'POSIXct')
# pHDataExpanded2 <- readWQPdata(bBox=c(-90.1,42.9,-89.9,43.1),
# characteristicName=nameToUse)
# expect_is(pHDataExpanded2$ActivityStartDateTime, 'POSIXct')

startDate <- as.Date("2013-01-01")
nutrientDaneCounty <- readWQPdata(countycode="US:55:025",startDate=startDate,
Expand Down

0 comments on commit c59ec8c

Please sign in to comment.