Updated WCS4_UTF16 to allow four octet wchar_t characters to marshal … #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…properly on Linux
mitza-oci
previously approved these changes
Oct 19, 2023
jwillemsen
reviewed
Oct 20, 2023
| if (this->write_4 (cdr, &l) && x != 0) | ||
| { | ||
| this->write_2 (cdr, &bom); | ||
| len--; |
There was a problem hiding this comment.
Updated commit just pushed. Let me know if you have other comments. Thanks!
|
Can you add/extend one of the unit tests as reproducer? |
Hi, I am willing to try to create a test, though I have not written or used any tests in the past. Is there any guidance as to where they are or how to build them? Is there an existing test that would make sense as the place to start from? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…properly on Linux
Associated to #2145