change sort ordering and date displays on dashboards #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipkcl
approved these changes
Nov 15, 2023
| @@ -95,6 +95,7 @@ def build_application(title, lmu_diff, cd_diff, status, editor=None): | |||
| ap.set_id(ap.makeid()) | |||
| ap.set_last_manual_update(dates.before(datetime.utcnow(), lmu_diff)) | |||
| ap.set_created(dates.before(datetime.utcnow(), cd_diff)) | |||
| ap.set_date_applied(dates.before(datetime.utcnow(), cd_diff)) | |||
| ap.set_application_status(status) | |||
There was a problem hiding this comment.
can be extract for other build_application to reuse
| @@ -158,6 +158,7 @@ def _rationalise_todos(self, todos, size): | |||
| class TodoRules(object): | |||
| @classmethod | |||
| def maned_stalled(cls, size, maned_of): | |||
| sort_date = "created_date" | |||
There was a problem hiding this comment.
can be extract to global variable default_rule_sort_field
Steven-Eardley
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a number of sort and date display issues on the dashboard pages
Please don't delete any sections when completing this PR template; instead enter N/A for checkboxes or sections which are not applicable, unless otherwise stated below
See https://github.com/DOAJ/doajPM/issues/3733
Changes the default sorting to admin.date_applied rather than created_date due to some oddities with the differences between these dates. Also uses admin.date_applied to display the date on the dashboard.
Categorisation
This PR...
Basic PR Checklist
Instructions for developers:
Instructions for reviewers:
Code Style
No deprecated methods are used
No magic strings/numbers - all strings are in
constantsormessagesfilesES queries are wrapped in a Query object rather than inlined in the code
Where possible our common library functions have been used (e.g. dates manipulated via
dates)Cleaned up commented out code, etc
Urls are constructed with
url_fornot hard-codedTesting
Unit tests have been added/modified
Functional tests have been added/modified
Code has been run manually in development, and functional tests followed locally
Have CSS/style changes been implemented? If they are of a global scope (e.g. on base HTML elements) have the downstream impacts of the change in other areas of the system been considered?
Documentation
FeatureMap annotations have been added
Documentation updates - if needed - have been identified and prepared for inclusion into main documentation (e.g. added and highlighted/commented as appropriate to this PR)
Core model documentation has been added to if needed: https://docs.google.com/spreadsheets/d/1lun2S9vwGbyfy3WjIjgXBm05D-3wWDZ4bp8xiIYfImM/edit
Events and consumers documentation has been added if needed: https://docs.google.com/spreadsheets/d/1oIeG5vg-blm2MZCE-7YhwulUlSz6TOUeY8jAftdP9JE/edit
The docs for this branch have been generated and pushed to the doc site (see docs/README.md for details)
Release Readiness
If needed, migration has been created and tested locally
Release sheet has been created, and completed as far as is possible https://docs.google.com/spreadsheets/d/1Bqx23J1MwXzjrmAygbqlU3YHxN1Wf7zkkRv14eTVLZQ/edit#gid=2141452874
There has been a recent merge up from
develop(or other base branch). List the dates of the merges up from develop belowTesting
The primary test for this feature is to confirm that in real operation it is giving editors the correct behaviour. To that end, the following testing needs to be applied:
In addition, the following regression testing is required for the feature itself:
Deployment
What deployment considerations are there? (delete any sections you don't need)
Configuration changes
N/A
Scripts
N/A
Migrations
N/A
Monitoring
N/A
New Infrastructure
N/A
Continuous Integration
N/A