Skip to content

Commit

Permalink
add validation to csv import (after main validation) to apply conditi…
Browse files Browse the repository at this point in the history
…onal field constraints
  • Loading branch information
richard-jones committed Dec 13, 2024
1 parent 92dbeee commit 4e84a88
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions portality/scripts/journals_update_via_csv.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,10 @@ def confirm_prompt():

try:
if not args.dry_run:
# FIXME: we have to validate, as this pre-filters conditional fields and makes other protections
# on the form values. This is not really ideal, as validate shouldn't really be changing the data!
fc.validate()

# Save the update request
fc.finalise(email_alert=False)
print('Update request created.')
Expand Down

0 comments on commit 4e84a88

Please sign in to comment.