Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] #239 - 네트워크 구조 변경 #240

Merged
merged 9 commits into from
Mar 11, 2024
Merged

[Refactor] #239 - 네트워크 구조 변경 #240

merged 9 commits into from
Mar 11, 2024

Conversation

jeongdung-eo
Copy link
Member

@jeongdung-eo jeongdung-eo commented Mar 10, 2024 •
edited
Loading

🫧 작업한 내용

  • 현재 API, Service를 뷰를 기준으로 나눴었는데 path를 기준으로 재분류했습니다.

🔫 PR Point

[ 문제점 ]

  • 기존의 싱글톤 객체로 구현된 API 객체는 여러 뷰 컨트롤러에 따라 필요한 API를 구현하함. 이 과정에서 API 객체마다 중복되는 API 구현으로 인해 중복 코드가 발생.
    case detailMission(id: Int) //case achieveDetail(missionId: Int )
    case particularMission(id: Int) //case missionDates(id: Int)

[ 해결 ]

  • 이를 VC 기준이 아닌 역할에 따라 API & Service 부분 변경

📸 스크린샷

구현 내용 스크린샷
GIF

📮 관련 이슈

@jeongdung-eo jeongdung-eo requested a review from yungu0010 March 10, 2024 12:57
@jeongdung-eo jeongdung-eo self-assigned this Mar 10, 2024
@jeongdung-eo jeongdung-eo merged commit 3c484f3 into develop Mar 11, 2024
1 check passed
@jeongdung-eo jeongdung-eo deleted the feat/#239 branch March 11, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yungu0010 yungu0010 Awaiting requested review from yungu0010

Assignees

@jeongdung-eo jeongdung-eo

Labels
refactor 정은
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactor] 네트워크 구조 변경
1 participant
@jeongdung-eo