fix: 代码质量与规范调整

DNSPod · Mar 13, 2024 · fc2f16a · fc2f16a
1 parent b558d67
commit fc2f16a
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 11 deletions.
diff --git a/build.gradle b/build.gradle
@@ -94,14 +94,10 @@ configurations {
 
 dependencies {
     implementation 'androidx.annotation:annotation:1.1.0'
-//    implementation files('libs/beacon-android-release-3.1.2-cover.jar')
     testImplementation 'junit:junit:4.12'
     androidTestImplementation('com.android.support.test.espresso:espresso-core:3.0.2', {
         exclude group: 'com.android.support', module: 'support-annotations'
     })
-//    implementation 'androidx.room:room-runtime:2.2.0'
-//    annotationProcessor 'androidx.room:room-compiler:2.2.0'
-
     doclava 'com.google.doclava:doclava:1.0.6'
 }
 

diff --git a/src/main/java/com/tencent/msdk/dns/base/network/NetworkChangeManager.java b/src/main/java/com/tencent/msdk/dns/base/network/NetworkChangeManager.java
@@ -6,7 +6,7 @@
 
 public final class NetworkChangeManager {
 
-    private volatile static INetworkChangeObservable sNetworkChangeObservable;
+    private static volatile INetworkChangeObservable sNetworkChangeObservable;
 
     public static void install(Context context) {
         if (null == context) {

diff --git a/src/main/java/com/tencent/msdk/dns/base/network/NetworkChangeObservableImpl.java b/src/main/java/com/tencent/msdk/dns/base/network/NetworkChangeObservableImpl.java
@@ -25,7 +25,7 @@ public void onReceive(Context context, Intent intent) {
                     mayChangeNetwork(appContext);
                 }
             }, new IntentFilter(ConnectivityManager.CONNECTIVITY_ACTION));
-        } catch (Exception e){
+        } catch (Exception e) {
             DnsLog.w("network register failed " + e);
         }
     }

diff --git a/src/main/java/com/tencent/msdk/dns/core/cache/database/CacheDbHelper.java b/src/main/java/com/tencent/msdk/dns/core/cache/database/CacheDbHelper.java
@@ -45,7 +45,7 @@ private SQLiteDatabase getDb() {
             try {
                 mDb = getWritableDatabase();
             } catch (Exception e) {
-
+                DnsLog.e("get db error " + e);
             }
         }
         return mDb;
@@ -54,7 +54,7 @@ private SQLiteDatabase getDb() {
     public List<LookupCache> getAll() {
         synchronized (mLock) {
             ArrayList<LookupCache> lists = new ArrayList<>();
-            SQLiteDatabase db = null;
+            SQLiteDatabase db;
             Cursor cursor = null;
 
             try {
@@ -76,7 +76,8 @@ public List<LookupCache> getAll() {
                     if (cursor != null) {
                         cursor.close();
                     }
-                } catch (Exception ignored) {
+                } catch (Exception e) {
+                    DnsLog.e("cursor close error " + e);
                 }
             }
             return lists;
@@ -100,7 +101,8 @@ public void insert(LookupCache lookupCache) {
                 if (db != null) {
                     try {
                         db.endTransaction();
-                    } catch (Exception ignored) {
+                    } catch (Exception e) {
+                        DnsLog.e("db end transaction error  " + e);
                     }
                 }
             }
@@ -128,7 +130,8 @@ public void delete(String[] hosts) {
                     if (db != null) {
                         try {
                             db.endTransaction();
-                        } catch (Exception ignored) {
+                        } catch (Exception e) {
+                            DnsLog.e("db end transaction error " + e);
                         }
                     }
                 }