Reload expired client certificates #2123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the client credentials used for mutual authentication expire, all requests to a DoH server which enforces validitiy will fail. To mitigate this, we can try to reload the existing credentials from disk. This assumes that the credentials have been rotated outside of the dnscrypt-proxy process and thus a reload will pick up the newest versions. The simplest way to do this is to simply rebuild the transport upon receiving an error which contains the string "bad certificate".
|
To test my changes, I no longer had a mutually-authenticated DoH server which does enforce certificate validity, so I pointed it to another random HTTPS endpoint which did. However, it doesn't speak DoH, so I didn't expect valid outputs when it got there: At this point, I flipped the certificate file to a non-expired version, and it reloaded properly, but now I had the issue of pointing at a non-DoH server, but at least what I was after worked! |
|
Thanks! It may work as a quick hack, but this is not something that can be merged as-is. If a single server has a permanent certificate error, that would cause the entire configuration to be reloaded every time it gets a query. Not great if more than one server is in use, and that can even be considered a remotely exploitable security issue. |
|
Also, the same issue may affect ODoH relays. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the client credentials used for mutual authentication expire, all requests
to a DoH server which enforces validitiy will fail. To mitigate this, we can
try to reload the existing credentials from disk. This assumes that the
credentials have been rotated outside of the dnscrypt-proxy process and thus a
reload will pick up the newest versions.
The simplest way to do this is to simply rebuild the transport upon receiving
an error which contains the string "bad certificate".
Resolves #2114