Skip to content

Commit

Permalink
Fixed wording to make it clearer
Browse files Browse the repository at this point in the history
  • Loading branch information
Diana-DNAstack committed Apr 25, 2024
1 parent 3dd6065 commit 99c2845
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions dnastack/cli/workbench/runs_commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -440,8 +440,8 @@ def write_logs(iterable: Iterable[bytes], writer):
arg_names=['--engine-params'],
help='Set the global engine parameters for all runs that are to be submitted. '
'Engine params can be specified as inlined JSON, json file preceded by the "@" symbol, '
'KV pair, parameter preset ID, or as a list of KV pairs and preset IDs separated by commas '
'(e.g. my-preset-id,key=value).',
'KV pair, parameter preset ID, or as a comma-separated-list containing any of those types '
'(e.g. my-preset-id,key=value,\'{"literal":"json"}\',@file.json).',
as_option=True,
default=None,
required=False
Expand Down Expand Up @@ -519,7 +519,7 @@ def get_default_engine_id():

if default_workflow_engine_parameters:
[param_ids_list, kv_pairs_list, json_literals_list,
files_list] = default_workflow_engine_parameters.separate_arguments_list()
files_list] = default_workflow_engine_parameters.extract_arguments_list()

param_presets = merge_param_json_data(kv_pairs_list, json_literals_list, files_list)

Expand Down
2 changes: 1 addition & 1 deletion dnastack/common/json_argument_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def parsed_value(self) -> JSONType:
else:
return json.loads(value)

def separate_arguments_list(self) -> Tuple[List[str], List[str], List[str], List[str]]:
def extract_arguments_list(self) -> Tuple[List[str], List[str], List[str], List[str]]:
# ordered as lists of param ids, kv pairs, json literals, files
params_ids = []
kv_pairs = []
Expand Down

0 comments on commit 99c2845

Please sign in to comment.