[#186091347] Create endpoints to clean up a run #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmagee
requested changes
Oct 19, 2023
There was a problem hiding this comment.
@Sean-DNAstack this is really great work and I am thoroughly impressed. There are a number of challenges that you encountered here and non trivial blocks of code. I have left a number of suggestions to improve readability and scalability.
src/main/java/com/dnastack/wes/storage/GcpBlobStorageClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/dnastack/wes/storage/LocalBlobStorageClient.java
Outdated
Show resolved
Hide resolved
patmagee
requested changes
Oct 20, 2023
There was a problem hiding this comment.
@Sean-DNAstack This is really coming along! Great work, I have left a few comments and have requested just a few changes
patmagee
requested changes
Oct 24, 2023
There was a problem hiding this comment.
@Sean-DNAstack you are almost there! I left a few comments and requested a few changes :)
e2e-tests/src/main/java/com/dnastack/wes/service/WesE2ETest.java
Outdated
Show resolved
Hide resolved
e2e-tests/src/main/java/com/dnastack/wes/service/WesE2ETest.java
Outdated
Show resolved
Hide resolved
e2e-tests/src/main/java/com/dnastack/wes/service/WesE2ETest.java
Outdated
Show resolved
Hide resolved
e2e-tests/src/main/java/com/dnastack/wes/service/WesE2ETest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/dnastack/wes/storage/client/local/LocalBlobStorageClientTest.java
Outdated
Show resolved
Hide resolved
Sean-DNAstack
requested review from
patmagee,
mpanik,
tianning-zhang and
daniel-thoo
patmagee
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secondaryfrom the applicable storage client.