Cleanup add captain hook

DMKEBUSINESSGMBH · Nov 27, 2024 · 211676e · 211676e
1 parent 75700ea
commit 211676e
Show file tree

Hide file tree

Showing 3 changed files with 72 additions and 9 deletions.
diff --git a/Classes/Controller/BackendModuleController.php b/Classes/Controller/BackendModuleController.php
@@ -29,16 +29,13 @@
 
 use DMK\Mklog\Domain\Model\DevlogEntryDemand;
 use DMK\Mklog\Domain\Repository\DevlogEntryRepository;
-use DMK\Mklog\Utility\VersionUtility;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
 use TYPO3\CMS\Backend\Attribute\AsController;
 use TYPO3\CMS\Backend\Template\ModuleTemplate;
 use TYPO3\CMS\Backend\Template\ModuleTemplateFactory;
-use TYPO3\CMS\Core\Http\HtmlResponse;
 use TYPO3\CMS\Core\Pagination\ArrayPaginator;
 use TYPO3\CMS\Core\Pagination\SimplePagination;
-use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Core\Utility\MathUtility;
 use TYPO3\CMS\Fluid\View\StandaloneView;
 
@@ -77,7 +74,7 @@ public function handleRequest(ServerRequestInterface $request): ResponseInterfac
         return $this->view->renderResponse('BackendModule');
     }
 
-    protected function getView(ServerRequestInterface $request)
+    protected function getView(ServerRequestInterface $request): ModuleTemplate
     {
         return $this->moduleTemplateFactory->create($request);
     }

diff --git a/captainhook.json b/captainhook.json
@@ -0,0 +1,59 @@
+{
+	"config": {
+		"vendor-directory": ".Build/vendor",
+		"bootstrap": ".Build/vendor/autoload.php"
+	},
+	"commit-msg": {
+		"enabled": true,
+		"actions": [
+			{
+				"action": "\\CaptainHook\\App\\Hook\\Message\\Action\\Beams",
+				"options": []
+			},
+			{
+				"action": "\\CaptainHook\\App\\Hook\\Message\\Action\\Regex",
+				"options": {
+					"regex": "#^(Cleanup|Bugfix|Version) .*#i",
+					"error": "Commit message has to start with ' #XXX' or 'Cleanup' or 'Bugfix' or 'Version'"
+				},
+				"conditions": []
+			}
+		]
+	},
+	"pre-push": {
+		"enabled": true,
+		"actions": [
+			{
+				"action": "composer test",
+				"options": [],
+				"conditions": []
+			}
+		]
+	},
+	"pre-commit": {
+		"enabled": true,
+		"actions": [
+			{
+				"action": "composer lint",
+				"options": [],
+				"conditions": []
+			}
+		]
+	},
+	"prepare-commit-msg": {
+		"enabled": false,
+		"actions": []
+	},
+	"post-commit": {
+		"enabled": false,
+		"actions": []
+	},
+	"post-merge": {
+		"enabled": false,
+		"actions": []
+	},
+	"post-checkout": {
+		"enabled": false,
+		"actions": []
+	}
+}
diff --git a/composer.json b/composer.json
@@ -52,7 +52,8 @@
         "phpstan/extension-installer": "^1.1",
         "saschaegerer/phpstan-typo3": "^1.0",
         "typo3/testing-framework": "^8.0 || ^9.0",
-        "ssch/typo3-rector": "^2.8"
+        "ssch/typo3-rector": "^2.8",
+        "captainhook/captainhook": "^5.10"
     },
     "autoload": {
         "classmap": [
@@ -93,14 +94,20 @@
         }
     },
     "scripts": {
+        "post-autoload-dump": [
+            "[ -e .Build/bin/captainhook ] && .Build/bin/captainhook install -f || echo 'CaptainHook missing, skip install.'"
+        ],
         "runqa": [
             "@fix",
             "@lint",
             "@test"
         ],
         "lint:php": [
             "[ -e .Build/bin/parallel-lint ] || composer update",
-            ".Build/bin/parallel-lint ./Classes"
+            "echo 'parallel-lint fails with a exception if executed inside the vendor/dmk/mklog folder'",
+            "[ -e ../../autoload.php ] && mv ../../autoload.php ../../autoload.php.bak",
+            ".Build/bin/parallel-lint ./Classes",
+            "[ -e ../../autoload.php.bak ] && mv ../../autoload.php.bak ../../autoload.php"
         ],
         "lint": [
             "@lint:php"
@@ -110,11 +117,11 @@
             ".Build/bin/php-cs-fixer fix -v --dry-run --diff  --ansi"
         ],
         "test:phpcompatibility": [
-            "@test:phpcompatibility:8"
+            "@test:phpcompatibility:8.x"
         ],
-        "test:phpcompatibility:8": [
+        "test:phpcompatibility:8.x": [
             "[ -e .Build/bin/phpcs ] || composer update",
-            ".Build/bin/phpcs --ignore=.Build/*,Resources/Private/PHP/* -p . --standard=.Build/vendor/phpcompatibility/php-compatibility/PHPCompatibility --runtime-set testVersion 8.1-8.3"
+            ".Build/bin/phpcs --ignore=.Build/*,Resources/Private/PHP/* -p . --standard=.Build/vendor/phpcompatibility/php-compatibility/PHPCompatibility --runtime-set testVersion 8.1-8.4"
         ],
         "test:phpmd": [
             "[ -e .Build/bin/phpmd ] || composer update --ansi",