fix panic on empty read from file #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emilengler |
|
Sorry for all the force pushes. Should be fine now. |
|
This does not work, since the |
dadada
changed the title
wucke13
approved these changes
Dec 9, 2022
cvengler
reviewed
Dec 9, 2022
| } else { | ||
| return Err(ErrorReturnCode::NotAvailable); | ||
| }; | ||
| if let Some((port, val)) = read.get(sampling_port_id as usize - 1) { |
There was a problem hiding this comment.
Can sampling_port_id be zero? I see potential for an unsigned integer wrap here. If not, I would comment it at least.
There was a problem hiding this comment.
The sampling_port_id is always greater than zero, since it is (incidentally) derived from the current length, after inserting an element, of the ArrayVec storing the sampling ports. https://github.com/aeronautical-informatics/apex-linux/pull/15/files#diff-d21de3347b5e6174c93c455b533568b798d139a47f7ba2564655c0731e27f889R120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #16 a read from an empty file or from the end of a file. I'm not entirely sure under which conditions the file can be empty, but the cursor might be moved between seeking it to the beginnging of the file and reading from it. I encountered the problem only occasionally when running the hypervisor with two partitions for a while.