Use Threads inside of Partitions instead of Processes #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevenautumns
force-pushed
the
dev/threaded_partitions
branch
4 times, most recently
from
4cb341e to
63bdfc3
Compare
|
Note: this should also close #85 |
dadada
approved these changes
Feb 23, 2024
| @@ -99,14 +79,6 @@ pub(crate) static UDP_IO_RX: Lazy<IoReceiver<UdpSocket>> = | |||
| pub(crate) static TCP_IO_RX: Lazy<IoReceiver<TcpStream>> = | |||
| Lazy::new(|| unsafe { IoReceiver::<TcpStream>::from_raw_fd(CONSTANTS.io_fd) }); | |||
|
|
|||
There was a problem hiding this comment.
Informational: It is a shame the socket needs to be connected in the hypervisor. We may think about using something like slirp for more flexible networking.
sevenautumns
force-pushed
the
dev/threaded_partitions
branch
2 times, most recently
from
e1f5000 to
02c031e
Compare
sevenautumns
force-pushed
the
dev/threaded_partitions
branch
from
02c031e to
45a9ba7
Compare
Inside of partitions threads are used for "processes" instead of processes. This means that arinc "processes" now share an address space
Replace `Ordering::Relaxed` with `Ordering::SeqCst` as a relaxed ordering may have unexpected behaviour. Also, the performance hit should not be significant.
sevenautumns
force-pushed
the
dev/threaded_partitions
branch
from
45a9ba7 to
c318df6
Compare
dadada
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.