Corrige un bug lié à l'ancienne gestion des critères transverses provoquant parfois des écrasements de données #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hissalht
commented
Nov 14, 2024
Comment on lines
-418
to
-464
| if (item.transverse) { | ||
| pages | ||
| .filter((page) => page.id !== item.pageId) | ||
| .forEach((page) => { | ||
| const data: Prisma.CriterionResultUpsertArgs["create"] = { | ||
| criterium: item.criterium, | ||
| topic: item.topic, | ||
| page: { | ||
| connect: { | ||
| id: page.id | ||
| } | ||
| }, | ||
|
|
||
| status: item.status, | ||
| transverse: true, | ||
|
|
||
| ...(item.status === CriterionResultStatus.COMPLIANT && { | ||
| compliantComment: item.compliantComment | ||
| }), | ||
|
|
||
| ...(item.status === CriterionResultStatus.NOT_COMPLIANT && { | ||
| notCompliantComment: item.notCompliantComment, | ||
| userImpact: item.userImpact, | ||
| quickWin: item.quickWin | ||
| }), | ||
|
|
||
| ...(item.status === CriterionResultStatus.NOT_APPLICABLE && { | ||
| notApplicableComment: item.notApplicableComment | ||
| }) | ||
| }; | ||
|
|
||
| result.push( | ||
| this.prisma.criterionResult.upsert({ | ||
| where: { | ||
| pageId_topic_criterium: { | ||
| criterium: item.criterium, | ||
| topic: item.topic, | ||
| pageId: page.id | ||
| } | ||
| }, | ||
| create: data, | ||
| update: data | ||
| }) | ||
| ); | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
Ce bloc de code avait été oublié lors du passage au nouveau système de critères transverses. Il provoquait des bugs d'écrasement de données avec les critères qui étaient anciennement marqués comme transverses (y compris dans des audits copiés)
bellangerq
approved these changes
Nov 14, 2024
hissalht
changed the title
bellangerq
changed the title
yaaax
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peut-être lié à #841 ?