Fix type issues (error messages can be strings)

DISIC · Nov 20, 2024 · b43fd9e · b43fd9e
1 parent a28acde
commit b43fd9e
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/confiture-web-app/src/components/audit/AuditGenerationCriterium.vue b/confiture-web-app/src/components/audit/AuditGenerationCriterium.vue
@@ -119,7 +119,7 @@ function toggleTransverseComment() {
 
 const notify = useNotifications();
 
-const errorMessage: Ref<FileErrorMessage | null> = ref(null);
+const errorMessage: Ref<FileErrorMessage | string | null> = ref(null);
 const criteriumNotCompliantAccordion =
   ref<InstanceType<typeof CriteriumNotCompliantAccordion>>();
 

diff --git a/confiture-web-app/src/components/audit/CriteriumNotCompliantAccordion.vue b/confiture-web-app/src/components/audit/CriteriumNotCompliantAccordion.vue
@@ -14,7 +14,7 @@ import MarkdownHelpButton from "./MarkdownHelpButton.vue";
 export interface Props {
   id: string;
   comment: string | null;
-  errorMessage?: FileErrorMessage | null;
+  errorMessage?: FileErrorMessage | string | null;
   exampleImages: AuditFile[];
   quickWin?: boolean;
   userImpact: CriterionResultUserImpact | null;

diff --git a/confiture-web-app/src/components/audit/NotesModal.vue b/confiture-web-app/src/components/audit/NotesModal.vue
@@ -28,7 +28,7 @@ defineExpose({
   hide: () => modal.value?.hide()
 });
 
-const errorMessage: Ref<FileErrorMessage | null> = ref(null);
+const errorMessage: Ref<FileErrorMessage | string | null> = ref(null);
 const fileUpload = ref<InstanceType<typeof FileUpload>>();
 
 const auditStore = useAuditStore();

diff --git a/confiture-web-app/src/components/ui/FileUpload.vue b/confiture-web-app/src/components/ui/FileUpload.vue
@@ -10,7 +10,7 @@ import { formatBytes, getUploadUrl } from "../../utils";
 export interface Props {
   acceptedFormats?: Array<string>;
   auditFiles: AuditFile[];
-  errorMessage?: FileErrorMessage | null;
+  errorMessage?: FileErrorMessage | string | null;
   maxFileSize?: string;
   multiple?: boolean;
   readonly?: boolean;

diff --git a/confiture-web-app/src/utils.ts b/confiture-web-app/src/utils.ts
@@ -245,7 +245,7 @@ export async function handleFileUploadError(
   error: Error
 ): Promise<FileErrorMessage | string> {
   if (error instanceof HTTPError) {
-    let errorType: FileErrorMessage | null = null;
+    let errorType: FileErrorMessage;
     if (error.response.status === 413) {
       errorType = FileErrorMessage.UPLOAD_SIZE;
     }