Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SM-287 / SM-290 #49

Merged
merged 19 commits into from
Nov 20, 2023
Merged

SM-287 / SM-290 #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f8f0b3f
draft new table template device definitions
lauradeng23 Nov 14, 2023
5568cf3
template device definition logic in GetConfigURLs function
lauradeng23 Nov 14, 2023
60539a6
updated migration
lauradeng23 Nov 15, 2023
9b29d9f
fixed query logic but not optimized yet
lauradeng23 Nov 15, 2023
a451564
refactored api logic
lauradeng23 Nov 16, 2023
354d40a
resolve rebase, update usage of get device defs
JamesReate Nov 16, 2023
556a94e
responded to some todo tasks
lauradeng23 Nov 17, 2023
d5b3488
added some tests
lauradeng23 Nov 17, 2023
0638ce3
move some stuff around
JamesReate Nov 17, 2023
a692c6b
readded logic for querying by powertrain and protocol
lauradeng23 Nov 17, 2023
fc2a81e
finished writing all tests, new tests all pass
lauradeng23 Nov 17, 2023
478ce5d
updated migration
lauradeng23 Nov 17, 2023
4585e76
improved error handling to prevent nil pointer issues
lauradeng23 Nov 17, 2023
30feb1a
fixed linter issue
lauradeng23 Nov 17, 2023
7b2a42b
all tests passing
lauradeng23 Nov 18, 2023
b4a493a
add failing test scenario
JamesReate Nov 20, 2023
b456a3c
handle some more edge cases, update tests
JamesReate Nov 20, 2023
5afe26e
fix test, add guard clauses
JamesReate Nov 20, 2023
70d7880
linter
JamesReate Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ require (
github.com/volatiletech/null/v8 v8.1.2
github.com/volatiletech/sqlboiler/v4 v4.15.0
github.com/volatiletech/strmangle v0.0.5
go.uber.org/mock v0.3.0
google.golang.org/grpc v1.57.0
google.golang.org/protobuf v1.31.0
)
Expand Down Expand Up @@ -88,7 +89,6 @@ require (
go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama v0.31.0 // indirect
go.opentelemetry.io/otel v1.15.1 // indirect
go.opentelemetry.io/otel/trace v1.15.1 // indirect
go.uber.org/mock v0.3.0 // indirect
golang.org/x/crypto v0.12.0 // indirect
golang.org/x/exp v0.0.0-20230522175609-2e198f4a06a1 // indirect
golang.org/x/mod v0.12.0 // indirect
Expand Down
1 change: 0 additions & 1 deletion go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,6 @@ github.com/golang/mock v1.4.1/go.mod h1:UOMv5ysSaYNkG+OFQykRIcU/QvvxJf3p21QfJ2Bt
github.com/golang/mock v1.4.3/go.mod h1:UOMv5ysSaYNkG+OFQykRIcU/QvvxJf3p21QfJ2Bt3cw=
github.com/golang/mock v1.4.4/go.mod h1:l3mdAwkq5BuhzHwde/uurv3sEJeZMXNpwsxVWU71h+4=
github.com/golang/mock v1.5.0/go.mod h1:CWnOUgYIOo4TcNZ0wHX3YZCqsaM1I1Jvs6v3mP3KVu8=
github.com/golang/mock v1.6.0 h1:ErTB+efbowRARo13NNdxyJji2egdxLGQhRaY+DUumQc=
github.com/golang/mock v1.6.0/go.mod h1:p6yTPP+5HYm5mzsMV8JkE6ZKdX+/wYM6Hr+LicevLPs=
github.com/golang/protobuf v1.2.0/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U=
github.com/golang/protobuf v1.3.1/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U=
Expand Down
320 changes: 220 additions & 100 deletions internal/controllers/device_config_controller.go
View file
Open in desktop

Large diffs are not rendered by default.

Loading