remove device battery signal

DIMO-Network · Oct 9, 2024 · 7771fcd · 7771fcd
1 parent d118b05
commit 7771fcd
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 83 deletions.
diff --git a/pkg/ruptela/multiplier-offset.go b/pkg/ruptela/multiplier-offset.go
diff --git a/pkg/ruptela/payload-status_test.go b/pkg/ruptela/payload-status_test.go
@@ -104,7 +104,6 @@ var (
 		{TokenID: 33, Timestamp: ts, Name: vss.FieldOBDDistanceWithMIL, ValueNumber: 0, Source: "ruptela/TODO"},
 		{TokenID: 33, Timestamp: ts, Name: vss.FieldPowertrainCombustionEngineTPS, ValueNumber: 0, Source: "ruptela/TODO"},
 		{TokenID: 33, Timestamp: ts, Name: vss.FieldPowertrainTransmissionTravelledDistance, ValueNumber: 0, Source: "ruptela/TODO"},
-		{TokenID: 33, Timestamp: ts, Name: vss.FieldLowVoltageBatteryCurrentVoltage, ValueNumber: 4224, Source: "ruptela/TODO"},
 		{TokenID: 33, Timestamp: ts, Name: vss.FieldSpeed, ValueNumber: 0, Source: "ruptela/TODO"},
 	}
 )
diff --git a/pkg/ruptela/schema/ruptela-definitions.yaml b/pkg/ruptela/schema/ruptela-definitions.yaml
@@ -61,13 +61,6 @@
   requiredPrivileges:
     - VEHICLE_NON_LOCATION_DATA
 
-- vspecName: Vehicle.LowVoltageBattery.CurrentVoltage
-  conversions:
-    - originalName: "signals.30" # Battery voltage
-      originalType: string
-  requiredPrivileges:
-    - VEHICLE_NON_LOCATION_DATA
-
 - vspecName: Vehicle.OBD.RunTime
   conversions:
     - originalName: "signals.107" # OBD time since engine start
@@ -188,6 +181,14 @@
       originalType: string
   requiredPrivileges:
     - VEHICLE_NON_LOCATION_DATA
+
+# TODO this is the voltage of the device not the vehicle
+# - vspecName: Vehicle.LowVoltageBattery.CurrentVoltage
+#   conversions:
+#     - originalName: "signals.30" # Battery voltage
+#       originalType: string
+#   requiredPrivileges:
+#     - VEHICLE_NON_LOCATION_DATA
 
 # TODO we only get batteryCapacity in percent SOH
 # - vspecName: Vehicle.Powertrain.TractionBattery.GrossCapacity

diff --git a/pkg/ruptela/vehicle-convert-funcs_gen.go b/pkg/ruptela/vehicle-convert-funcs_gen.go
diff --git a/pkg/ruptela/vehicle-v1-convert_gen.go b/pkg/ruptela/vehicle-v1-convert_gen.go