Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example notebook for showing node connectivity information #24

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Example notebook for showing node connectivity information #24

merged 3 commits into from
Mar 21, 2024

Conversation

ryan-kipawa
Copy link
Collaborator

No description provided.

@ryan-kipawa
Copy link
Collaborator Author

ryan-kipawa commented Mar 7, 2024 •
edited
Loading

@wuwwen A few questions:

  1. What do GetUpstreamLinks and GetDownstreamLinks return? They appear the opposite of what I would expect.
  2. What does GetNumberofLinks return? It seems to include all links (e.g. pipes, pumps, weirs etc.), whereas GetUpstreamLinks / GetDownstreamLinks seem to only pipes/canals.

@wuwwen
Copy link
Collaborator

wuwwen commented Mar 12, 2024

@rywm-dhi GetUpstreamLinks is find all the links which has the same FromNodeID with input node id. It is the look the links which have the node on the upstream. It will only search for the links. Valves, pumps or other structure is not included.

@ryan-kipawa ryan-kipawa marked this pull request as ready for review March 21, 2024 08:08
@ryan-kipawa ryan-kipawa merged commit d18f131 into main Mar 21, 2024
1 check passed
@ryan-kipawa ryan-kipawa deleted the notebook/node_connectivity_information branch October 31, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan-kipawa @wuwwen