Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pfs - handle slow reading of MIKE Hydro #750

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Pfs - handle slow reading of MIKE Hydro #750

merged 2 commits into from
Nov 19, 2024

Conversation

ecomodeller
Copy link
Member

MIKE Hydro pfs files have catchment defined as WKT MULTIPOLYGON which can have many commas.

Closing #749

@ecomodeller ecomodeller linked an issue Nov 19, 2024 that may be closed by this pull request
@jsmariegaard
Copy link
Member

Nice simple solution

@ecomodeller ecomodeller marked this pull request as ready for review November 19, 2024 12:13
Copy link
Contributor

@ryan-kipawa ryan-kipawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit verbose, but looks good 😛

@ecomodeller ecomodeller merged commit e8c87b8 into main Nov 19, 2024
13 checks passed
@ecomodeller ecomodeller deleted the pfs_many_commas branch November 19, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very slow reading of mhydro file
3 participants