Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First step towards html repr #486

Closed
wants to merge 11 commits into from
Closed

First step towards html repr #486

wants to merge 11 commits into from

Conversation

ecomodeller
Copy link
Member

repr

@jsmariegaard
Copy link
Member

😍

@ecomodeller
Copy link
Member Author

Some challenges remain, mainly that the top level Pfs is not a PfsSection
pfs_repr_html2

@jsmariegaard
Copy link
Member

Wauw. Looks great!

Let's make another pull request by refactoring a common class _PfsBase from Pfs and PfsSection! (or maybe simply make Pfs inherit from PfsSection)?

@ecomodeller
Copy link
Member Author

This PR will be revived once #487 has been completed.

@jsmariegaard
Copy link
Member

This PR will be revived once #487 has been completed.

Are you trying to stress me 😛 ?

@ecomodeller
Copy link
Member Author

No, note to self

@ecomodeller
Copy link
Member Author

TODO: handle aliases
image

@ecomodeller
Copy link
Member Author

It works great in VS Code, but in Jupyter Lab/Notebook the css is not interpreted in the same way for some reasone
image

The list bullets should be hidden by this:☹️

ul {list-style-type: none; }

@ecomodeller
Copy link
Member Author

summary/details html Seems like a better structure than using CSS🤔 https://www.w3schools.com/tags/tag_summary.asp

@ecomodeller
Copy link
Member Author

Interesting, but for now we stick to a simple text.

@ecomodeller ecomodeller mentioned this pull request Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecomodeller @jsmariegaard