-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To become: Stonesense Docs and Changelog Update #121
Closed
realSquidCoder
wants to merge
30
commits into
DFHack:master
from
SquidCoderIndustries:squid-config-rewrite
Closed
To become: Stonesense Docs and Changelog Update #121
realSquidCoder
wants to merge
30
commits into
DFHack:master
from
SquidCoderIndustries:squid-config-rewrite
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
split segmentsize xy into x and y separately. also added code to handle showing and hiding announcements separately from the rest of the OSD
this also has the changes made in #120 |
this shouldnt be in this branch but oh well
myk002
reviewed
Jan 1, 2025
reverted the logging commit as it crashed the game. Added show_announcements to supported keybinds, defaults to `a`. Cleaned up the keybinds text file.
realSquidCoder
changed the title
Stonesense config rewrite
Stonesense config rewrite Part 1
Jan 8, 2025
stonesense can be resized as normal on the main menu. resizing it with a fort loaded will cause stonesense to close upon fort unload. this is another crash dodge
im gonna call this good for part 1 |
realSquidCoder
changed the title
Stonesense config rewrite Part 1
Stonesense Resize Crash Fix and Config Rewrite Part 1
Jan 9, 2025
realSquidCoder
force-pushed
the
squid-config-rewrite
branch
from
January 10, 2025 00:38
2b2f208
to
63e54da
Compare
so this was a lie |
the docs fail is bc i moved the |
Would like to fix #13 b4 merge |
realSquidCoder
added a commit
to SquidCoderIndustries/dfhack
that referenced
this pull request
Jan 10, 2025
Update the Stonesense docs to tell about using OpenGL on Windows for stability and reflect the changes made in DFHack/stonesense#121 Also added a note about our need for some missing art in stonesense (we don't have sprites for bookcases and pedestals for example)
realSquidCoder
force-pushed
the
squid-config-rewrite
branch
from
January 10, 2025 19:53
4faa4be
to
7cb4788
Compare
The "desmell" PR caused a few merge conflicts. Could you merge |
realSquidCoder
changed the title
Stonesense Resize Crash Fix and Config Rewrite Part 1
~~Stonesense Resize Crash Fix and Config Rewrite Part 1~~ To become: Stonesense Docs and Changelog Update
Jan 13, 2025
realSquidCoder
changed the title
~~Stonesense Resize Crash Fix and Config Rewrite Part 1~~ To become: Stonesense Docs and Changelog Update
~Stonesense Resize Crash Fix and Config Rewrite Part 1~ To become: Stonesense Docs and Changelog Update
Jan 13, 2025
realSquidCoder
changed the title
~Stonesense Resize Crash Fix and Config Rewrite Part 1~ To become: Stonesense Docs and Changelog Update
To become: Stonesense Docs and Changelog Update
Jan 13, 2025
What was i thinking, making a PR this big? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gonna be rewriting the config code as much as i can to make adding new configs easier.