Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To become: Stonesense Docs and Changelog Update #121

Closed

Conversation

realSquidCoder
Copy link
Contributor

Gonna be rewriting the config code as much as i can to make adding new configs easier.

split segmentsize xy into x and y separately. also added code to handle showing and hiding announcements separately from the rest of the OSD
@realSquidCoder
Copy link
Contributor Author

this also has the changes made in #120

this shouldnt be in this branch but oh well
CMakeLists.txt Outdated Show resolved Hide resolved
reverted the logging commit as it crashed the game. Added show_announcements to supported keybinds, defaults to `a`. Cleaned up the keybinds text file.
@realSquidCoder realSquidCoder changed the title Stonesense config rewrite Stonesense config rewrite Part 1 Jan 8, 2025
@realSquidCoder
Copy link
Contributor Author

im gonna call this good for part 1

@realSquidCoder realSquidCoder marked this pull request as ready for review January 9, 2025 01:15
@realSquidCoder realSquidCoder changed the title Stonesense config rewrite Part 1 Stonesense Resize Crash Fix and Config Rewrite Part 1 Jan 9, 2025
@realSquidCoder
Copy link
Contributor Author

im gonna call this good for part 1

so this was a lie

@realSquidCoder
Copy link
Contributor Author

This PR fixes: #105 #98 #89 #87 #38 #18 #69 afaik

@realSquidCoder
Copy link
Contributor Author

the docs fail is bc i moved the keybinds.txt file

@realSquidCoder
Copy link
Contributor Author

Would like to fix #13 b4 merge

realSquidCoder added a commit to SquidCoderIndustries/dfhack that referenced this pull request Jan 10, 2025
Update the Stonesense docs to tell about using OpenGL on Windows for stability and reflect the changes made in DFHack/stonesense#121

Also added a note about our need for some missing art in stonesense (we don't have sprites for bookcases and pedestals for example)
@myk002
Copy link
Member

myk002 commented Jan 12, 2025

This PR fixes: #105 #98 #89 #87 #38 #18 #69 afaik

this needs to go in the main PR description in order for it to take effect and link the issues to close with this PR

@myk002
Copy link
Member

myk002 commented Jan 12, 2025

The "desmell" PR caused a few merge conflicts. Could you merge master into this PR and clean up the conflicts?

@realSquidCoder realSquidCoder changed the title Stonesense Resize Crash Fix and Config Rewrite Part 1 ~~Stonesense Resize Crash Fix and Config Rewrite Part 1~~ To become: Stonesense Docs and Changelog Update Jan 13, 2025
@realSquidCoder realSquidCoder changed the title ~~Stonesense Resize Crash Fix and Config Rewrite Part 1~~ To become: Stonesense Docs and Changelog Update ~Stonesense Resize Crash Fix and Config Rewrite Part 1~ To become: Stonesense Docs and Changelog Update Jan 13, 2025
@realSquidCoder realSquidCoder changed the title ~Stonesense Resize Crash Fix and Config Rewrite Part 1~ To become: Stonesense Docs and Changelog Update To become: Stonesense Docs and Changelog Update Jan 13, 2025
@realSquidCoder realSquidCoder marked this pull request as draft January 13, 2025 18:26
@realSquidCoder
Copy link
Contributor Author

What was i thinking, making a PR this big?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants