Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-repo changelog to stonesense. #118

Merged
merged 5 commits into from
Dec 27, 2024

Conversation

realSquidCoder
Copy link
Contributor

@realSquidCoder realSquidCoder commented Dec 26, 2024

See: #117

Comment on lines 27 to 41
## New Tools

## New Features

## Fixes

## Misc Improvements

## Documentation

## API

## Lua

## Removed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## New Tools
## New Features
## Fixes
## Misc Improvements
## Documentation
## API
## Lua
## Removed
## Fixes
## Misc Improvements

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect the template can be reduced to just those two headers. The other categories don't make much sense for the stonesense repo

Copy link
Contributor Author

@realSquidCoder realSquidCoder Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we should also leave Documentation and New Features? Matbe also removed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stonesense's docs are in the DFHack/dfhack repo. New Features could still be useful, depending on what you have a mind.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd move this into the docs directory so it isn't more visible than the new "real" changelog.txt

I'd also recommend renaming it to history.txt to keep things short

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, will change in next commit

- `stonesense`: changed announcements to be right-aligned and limited it to only show the most recent 10 announcements.

## Documentation
- `stonesense`: added a changelog in the stonesense repo itself (stonesense/docs/changelog.txt).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes that are not user-facing do not need to go in the changelog. only things that would go in the public release notes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, is it not redundant to say stonesense? What should we do instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stonesense is not as redundant as it seems. this file will get aggregated with the changelogs in the other repos and they all appear as a unified document in the release notes. We could potentially auto-inject a "stonesense" prefix, but that seems like more complexity than what is needed.

@realSquidCoder realSquidCoder marked this pull request as ready for review December 26, 2024 23:14
docs/changelog.txt Outdated Show resolved Hide resolved
@myk002 myk002 merged commit c7893a1 into DFHack:master Dec 27, 2024
3 checks passed
@realSquidCoder realSquidCoder deleted the squid-changelogs branch December 27, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants