Fix a crash with pre-existing campsite #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
approved these changes
Apr 9, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a possible crash when entering
GetTerrainSpriteMapwith an unsupported form. This would leavetempformuninitialized, later leading to an out of bound access. At the moment the fix is to just return the default sprite.Note: I am completely unfamiliar with the codebase, and was not able to understand this situation "in context", so maybe there is a better way to fix that.
In my crash, I had:
Which would translate to the material
PLANT:FLAX:THREAD/linenand form would beCLOTH?On my map they come from some pre-existing campsite and crashes as soon as one of the "tent" is in sight. This change is likely a fix for #75 given how similar the situation is.