-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trackstop and rollers overlays #884
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest adding a CLI so this script can be used to programmatically alter the properties of track stops, for example as part of a dwarfputing setup
Also needs docs (docs/trackstop.rst) and a changelog entry (changelog.txt)
1fc3e1a
to
5642081
Compare
5642081
to
7d184a9
Compare
Added docs and changelog entry! CLI would be cool. You think it would be alright if we do that in a separate PR? I won't be able to finish that up today and not sure exactly when I'll get around to it. Could be very soon... or not 😅. Also realized that trackstop.cpp dealt with rollers too, so I should probably investigate those at some point too (before removing old trackstop stuff anyways). Edit: Adding rollers now actually. Should be very quick. |
Updated with rollers. trackstop.cpp handled both trackstops and rollers without being named in such a way to indicate that. Should we change the name of this script to something like trackstoprollers.lua or leave as is? |
Leave it as it is, I think. |
Is that backwards? If the arrow is up, then you're dumping to the north, and |
The direction thing I mentioned only applies to the roller direction: rollerdirection.mp4Dump direction for stops is handled by |
I also added directions.mp4 |
will merge once the |
trackstop.lua
Outdated
function TrackStopOverlay:onInput(keys) | ||
if not self:shouldRender() then | ||
return | ||
end | ||
TrackStopOverlay.super.onInput(self, keys) | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I forgot -- can this function be removed?
trackstop.lua
Outdated
if not self:shouldRender() then | ||
return | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be removed?
Add overlay for changing dump direction and friction of track stops after construction. If this is accepted, I can do a follow-up to remove the old trackstop.cpp stuff.
trackstop.mp4
Some screenshots showing how it looks with various suspend manager/building plan states:
Also adds rollers overlay (same position, size, most of the same options):
rollers.mp4
The directions appear to be flipped here but I double checked them against freshly built ones. When you press the arrow up and build the result is "FromSouth" and so on.