Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burial update #859

Merged
merged 7 commits into from
Oct 14, 2023
Merged

Burial update #859

merged 7 commits into from
Oct 14, 2023

Conversation

tmqCypher
Copy link
Contributor

Reworked the burial script to create minimal tombs for each coffin building, allowing things to be buried in them.

Also modified the options to allow for designating dwarf-only, pet-only, or general purpose tombs.

@tmqCypher
Copy link
Contributor Author

pre-commit.ci autofix

burial.lua Outdated Show resolved Hide resolved
docs/burial.rst Outdated Show resolved Hide resolved
docs/burial.rst Outdated Show resolved Hide resolved
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be sure to also add a note to changelog.txt to document that this tool has been updated and reinstated

burial.lua Outdated Show resolved Hide resolved
docs/burial.rst Outdated Show resolved Hide resolved
docs/burial.rst Outdated Show resolved Hide resolved
Comment on lines +30 to +32
``burial -cp``
Create tombs with automatic burial disabled for both citizens and pets,
requiring manual assignment of deceased units to each tomb.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. I like that you documented this use case

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Two options logically excluding each other probably isn't the most semantically straightforward way to access a feature, but it puts the docs to good use

@myk002
Copy link
Member

myk002 commented Oct 14, 2023

https://www.reddit.com/r/dwarffortress/comments/177qez1/the_weremarmot_infection_was_stopped_but_the/ could have used this : )

burial.lua Outdated Show resolved Hide resolved
@myk002 myk002 merged commit 9c77c52 into DFHack:master Oct 14, 2023
9 checks passed
@tmqCypher tmqCypher deleted the burial_update branch October 14, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants