-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update markup_text_boxst
#679
Conversation
wrong base branch, sorry |
e9c92b0
to
fb6246f
Compare
No types appear to have changed sizes in this pull request. (This comment is left behind if previous size changes were identified.) This is an automated comment. Please leave a reply if you think that the above information is incorrect. |
Should we maintain the init-values for
|
i'll add the init-values, i missed them working from toady's source because he uses a constructor function to set them instead of specifying them as defaults (as a note: you are free to use github's code review mechanism to suggest changes to a pending PR, that's why we use PRs) the problem with making |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on the purpose of some fields.
update comments Co-Authored-By: Ryan Williams <[email protected]>
You left in the "subid: " part of the subid comment and left out the ending ')' for py. |
this PR is based on bay12 header files and addresses issues raised in #569 and #574