Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update markup_text_boxst #679

Merged
merged 5 commits into from
Nov 23, 2023
Merged

update markup_text_boxst #679

merged 5 commits into from
Nov 23, 2023

Conversation

ab9rf
Copy link
Member

@ab9rf ab9rf commented Nov 21, 2023

this PR is based on bay12 header files and addresses issues raised in #569 and #574

@ab9rf
Copy link
Member Author

ab9rf commented Nov 21, 2023

wrong base branch, sorry

Copy link
Contributor

github-actions bot commented Nov 21, 2023

No types appear to have changed sizes in this pull request. (This comment is left behind if previous size changes were identified.)

This is an automated comment. Please leave a reply if you think that the above information is incorrect.

@Bumber64
Copy link
Contributor

Bumber64 commented Nov 21, 2023

Should we maintain the init-values for markup_text_wordst? Those are set in a constructor function. Same for markup_text_linkst's id and subid, unless those default to -1 automatically. (Was going to update the comments on these, so I can do this in a separate PR, since this one's ready to merge.)

Is it possible to do a refers-to on link_index such that gui/gm-editor can jump to the ref, or does that only work when something's global? Just going to assume "no, because pointers."

@ab9rf
Copy link
Member Author

ab9rf commented Nov 21, 2023

i'll add the init-values, i missed them working from toady's source because he uses a constructor function to set them instead of specifying them as defaults (as a note: you are free to use github's code review mechanism to suggest changes to a pending PR, that's why we use PRs)

the problem with making link-index jumpable in gm-editor is that the logic to figure out what to jump to is probably more complicated than gm-editor is currently capable of understanding

Copy link
Contributor

@Bumber64 Bumber64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on the purpose of some fields.

df.ui-menus.xml Outdated Show resolved Hide resolved
df.ui-menus.xml Outdated Show resolved Hide resolved
update comments

Co-Authored-By: Ryan Williams <[email protected]>
@Bumber64
Copy link
Contributor

You left in the "subid: " part of the subid comment and left out the ending ')' for py.

@myk002 myk002 merged commit e15ef6c into DFHack:master Nov 23, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants