Remove unnecessary Big Query environment variable #7356
+8
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
The infrastructure team is enabling federated authentication for big query and came across some inconsistency in environment variables. We are using BIG_QUERY_DATASET and BIGQUERY_DATASET.
After some investigation, it seems the former was set up originally when we started sending data to Big Query with custom events. Later we started using the latter when we introduced dfe-analytics without ever deleting or migrating the environment variable.
Old environment variable
https://github.com/DFE-Digital/teaching-vacancies/blob/main/config/application.rb#L127
New environment variable (also present in AWS parameter store)
https://github.com/DFE-Digital/teaching-vacancies/blob/main/config/initializers/dfe_analytics.rb#L24