Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove s165 terraform #1301

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

remove s165 terraform #1301

wants to merge 3 commits into from

Conversation

aje54
Copy link

@aje54 aje54 commented Jan 17, 2025

Context

to remove unused S165 terraform code

Changes proposed in this pull request

from /terraform dir remove everything except /../application and /../domains

Guidance to review

Check there are no S165 terraform references

Link to Trello card

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@aje54 aje54 requested a review from a team as a code owner January 17, 2025 14:42
@aje54 aje54 requested review from RMcVelia and removed request for a team January 17, 2025 14:42
@saliceti
Copy link
Member

Can we update more things:

$(eval AZURE_SUBSCRIPTION=s165-teachingqualificationsservice-production)
$(eval RESOURCE_NAME_PREFIX=s165p01)
$(eval ENV_SHORT=pd)
$(eval ENV_TAG=prod)

domains:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything until line 178 can go I think

@aje54 aje54 force-pushed the remove-s165-terraform branch from 4b01444 to 2487893 Compare January 20, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants