Update Rubocop GOVUK to 5.0.2 #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are a couple of major versions behind the GOVUK Rubocop rules. This change updates the linter and applies the corrections these new rules introduce.
felixclack
force-pushed
the
update-rubocop
branch
from
ac03194 to
aff2c3d
Compare
The specs for the malware scanning job don't contain an assertion and also don't pass when you add an assertion. This change fixes these and also introduces another test that was missing related to not running the malware scan.
richardpattinson
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are a couple of major versions behind the GOVUK Rubocop rules.
This change updates the linter and applies the corrections these new
rules introduce.