270 Dashboard Filters. #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor multiple queries used to generate KPIs, allowing for more flexible date range scopes. Update the system admin dashboard UI to add simple links to filter KPIs based on predefined date ranges aligned with the application windows. Additionally to help with local ssl testing, add cert.pem, key.pem to .gitignore.
The external links in erb templates have been updated to open in a new tab using the 'new_tab: true' attribute instead of 'target: "_blank"'. This change was required to support the latest view_component gem that was required by the govuk_components gem. The versions of dependencies 'puma' and 'govuk-components' in the Gemfile have been updated to the latest to address the security advisories.
This reverts commit 268bad4.
… to ensure security vulnerabilities are addressed. Add CVE-2024-21636 to be ignored in the bundler audit configuration.
Add missing tests to ensure the filters work in all queries. Extract common logic into new InflectionHelper. Refactor "time_to_" queries code reuse. Extend test coverage to ensure that the day calculation and pluralization are accurate for all cases.
Reyko
approved these changes
Jan 29, 2024
…' before 'joins' method in several query classes. Make 'window' a readable attribute.
… the bundler-audit configuration file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor multiple queries used to generate KPIs, allowing for more flexible date range scopes. Update the system admin dashboard UI to add simple links to filter KPIs based on predefined date ranges aligned with the application windows.
Additionally to help with local ssl testing, add cert.pem, key.pem to .gitignore.
Trello Card Link
https://trello.com/c/6iP14Inp/270-dashboard-updates-by-application-window