Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contract start date rules (#265) #360

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

eddieleeper
Copy link
Contributor

@eddieleeper eddieleeper commented Dec 20, 2023

Description

Upgrade the code for the eligibility check on the form for the contract start date, so that it works as expected in 2024.
Added the option to configure a 5 month window for the date as an alternative to the default of 6. The custom rails configuration entry config.x.form_eligibility.contract_start_months_limit can be set to 5 to allow this. If the entry is set to anything other than 5 or 6 it will default to 6 months.

Trello Card Link

Fix for contract start date

app/models/form/eligibility_check.rb Outdated Show resolved Hide resolved
app/models/form/eligibility_check.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@fumimowdan fumimowdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eddieleeper eddieleeper merged commit 86f40f3 into main Dec 20, 2023
6 checks passed
@eddieleeper eddieleeper deleted the bug/265-contract-start-date branch December 20, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants