Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add report reset button #343

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Add report reset button #343

merged 4 commits into from
Dec 5, 2023

Conversation

fumimowdan
Copy link
Contributor

@fumimowdan fumimowdan commented Dec 1, 2023

Description

In order to render the ops teams self sufficient add the ability to reset a specific report when a error has occured. (ie file lost)

Condition:
When feature Flipper.enabled?(:reset_reports)
and the current user has the role admin
and the report has not been already resetted
Then display a reset report button

Screenshots
Before:
image

After:
image

After reset report:
image

@fumimowdan fumimowdan force-pushed the feature/reset-report branch 4 times, most recently from 64fc520 to 6caea43 Compare December 4, 2023 10:23
This method will be invoked when a report will need resetting in case
of download error or lost report file.
This POST endpoint call the `Report.reset` service function define earlier
This button is presented only for report audit entries that are resetable.
Refactored audit index page
@fumimowdan fumimowdan force-pushed the feature/reset-report branch from 6caea43 to 2df6bc3 Compare December 4, 2023 10:24
app/helpers/audit_message_helper.rb Outdated Show resolved Hide resolved
app/services/report.rb Outdated Show resolved Hide resolved
app/services/report.rb Outdated Show resolved Hide resolved
spec/helpers/audit_message_helper_spec.rb Outdated Show resolved Hide resolved
spec/helpers/audit_message_helper_spec.rb Outdated Show resolved Hide resolved
@fumimowdan fumimowdan merged commit 4b60fe1 into main Dec 5, 2023
6 checks passed
@fumimowdan fumimowdan deleted the feature/reset-report branch December 5, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants