Code cleanup #259
Merged
Code cleanup #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SubmitForm service creates submitted application and we no longer have unsubmitted applications to consider in the system-admin code. The Forms are now what used to be unsubmitted applications.
Retreive the applicant email address directly instead of using the application instance.
raul-gracia
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove concept of submitted application
The SubmitForm service creates submitted application and we no longer
have unsubmitted applications to consider in the system-admin code.
The Forms are now what used to be unsubmitted applications.
Trello Card Link
https://trello.com/c/hr5LvhT7/205-code-cleanup