Fix Application urn #258
Closed
Fix Application urn #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URN is used as an ID type for Home Office csv however this class that does not generate urn with unique urn.
The SubmitForm service creates an application when users submit their forms. So we only have submitted applications and having the distinction between not_submitted and submitted application is not relevant anymore.
* create sequence * migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change how the application urn is generated.
This implementation rely on a new DB sequence
urn_sequenceassign toapplications.urn_suffixand 2 other columnsurn_prefixdefaulting to "IRP" andurn_codewhich depends on the application route.Previous implementation did not guaranty uniqueness.