-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Govuk Notify Mailer #240
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fumimowdan
force-pushed
the
feature/133-notify-mailer
branch
from
September 12, 2023 11:42
35cef14
to
eb5a63e
Compare
fumimowdan
force-pushed
the
feature/133-notify-mailer
branch
from
September 12, 2023 12:05
eb5a63e
to
52fbe09
Compare
raul-gracia
approved these changes
Sep 13, 2023
fumimowdan
force-pushed
the
feature/133-notify-mailer
branch
2 times, most recently
from
September 13, 2023 15:18
b468451
to
4ebd6a6
Compare
fumimowdan
force-pushed
the
feature/133-notify-mailer
branch
2 times, most recently
from
September 13, 2023 15:39
ae810fe
to
723149f
Compare
fumimowdan
force-pushed
the
feature/133-notify-mailer
branch
from
September 13, 2023 16:39
f040c60
to
4b80f25
Compare
fumimowdan
force-pushed
the
feature/133-notify-mailer
branch
from
September 14, 2023 07:45
4b80f25
to
2517e75
Compare
fumimowdan
force-pushed
the
feature/133-notify-mailer
branch
from
September 14, 2023 09:30
2517e75
to
0a38c1f
Compare
Activate for all environments
The `application_submission` method send a email with the body set in the `app/views/govuk_notify_mailer/application_submission.text.erb` file. A govuk notify template has been created to support this functionality.
GOVUK_NOTIFY_MAIL_NOTIFY_TEMPLATE_ID to GOVUK_NOTIFY_GENERIC_EMAIL_TEMPLATE_ID
execute command rake assets:precompile after the defining docker build arguments
fumimowdan
force-pushed
the
feature/133-notify-mailer
branch
from
September 14, 2023 09:36
0a38c1f
to
e9b94ee
Compare
fumimowdan
force-pushed
the
feature/133-notify-mailer
branch
from
September 14, 2023 10:05
e9b94ee
to
e1449f5
Compare
Run rails db:seed in review environment when app starts Updated Dockerfile to use a app startup shell script for that effect
starts one worker instance
fumimowdan
force-pushed
the
feature/133-notify-mailer
branch
from
September 14, 2023 10:25
e1449f5
to
4ce5ac0
Compare
This environment variable was used by the old govuk notify client and is not in use anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setup the gem mail-notify to work with the govuk notify new template called
Mail notify template
.Removed the Govuk Client and use the new GovukNotifyMailer in the SubmitForm service as a MailJob
Dependency
Trello Card Link
133-m-use-govuk-notify-mailer