Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Govuk Notify Mailer #240

Merged
merged 11 commits into from
Sep 14, 2023
Merged

Use Govuk Notify Mailer #240

merged 11 commits into from
Sep 14, 2023

Conversation

fumimowdan
Copy link
Contributor

@fumimowdan fumimowdan commented Sep 12, 2023

Description

Setup the gem mail-notify to work with the govuk notify new template called Mail notify template.

Removed the Govuk Client and use the new GovukNotifyMailer in the SubmitForm service as a MailJob

Dependency

Trello Card Link

133-m-use-govuk-notify-mailer

@fumimowdan fumimowdan force-pushed the feature/133-notify-mailer branch from 35cef14 to eb5a63e Compare September 12, 2023 11:42
@fumimowdan
Copy link
Contributor Author

@fumimowdan fumimowdan force-pushed the feature/133-notify-mailer branch from eb5a63e to 52fbe09 Compare September 12, 2023 12:05
Base automatically changed from feature/151-delete-stale-forms to main September 13, 2023 14:25
@fumimowdan fumimowdan force-pushed the feature/133-notify-mailer branch 2 times, most recently from b468451 to 4ebd6a6 Compare September 13, 2023 15:18
@fumimowdan fumimowdan added the deploy Deploy review app label Sep 13, 2023
@github-actions github-actions bot temporarily deployed to review-240 September 13, 2023 15:31 Destroyed
@fumimowdan fumimowdan force-pushed the feature/133-notify-mailer branch 2 times, most recently from ae810fe to 723149f Compare September 13, 2023 15:39
@fumimowdan fumimowdan added deploy Deploy review app and removed deploy Deploy review app labels Sep 13, 2023
@github-actions github-actions bot temporarily deployed to review-240 September 13, 2023 15:47 Destroyed
@github-actions github-actions bot temporarily deployed to review-240 September 13, 2023 16:08 Destroyed
@fumimowdan fumimowdan force-pushed the feature/133-notify-mailer branch from f040c60 to 4b80f25 Compare September 13, 2023 16:39
@github-actions github-actions bot temporarily deployed to review-240 September 13, 2023 16:42 Destroyed
@fumimowdan fumimowdan force-pushed the feature/133-notify-mailer branch from 4b80f25 to 2517e75 Compare September 14, 2023 07:45
@github-actions github-actions bot temporarily deployed to review-240 September 14, 2023 07:49 Destroyed
@fumimowdan fumimowdan force-pushed the feature/133-notify-mailer branch from 2517e75 to 0a38c1f Compare September 14, 2023 09:30
@github-actions github-actions bot temporarily deployed to review-240 September 14, 2023 09:31 Destroyed
Activate for all environments
The `application_submission` method send a email with the body set in
the `app/views/govuk_notify_mailer/application_submission.text.erb`
file.

A govuk notify template has been created to support this functionality.
GOVUK_NOTIFY_MAIL_NOTIFY_TEMPLATE_ID to GOVUK_NOTIFY_GENERIC_EMAIL_TEMPLATE_ID
execute command rake assets:precompile after the defining docker build
arguments
@fumimowdan fumimowdan force-pushed the feature/133-notify-mailer branch from 0a38c1f to e9b94ee Compare September 14, 2023 09:36
@github-actions github-actions bot temporarily deployed to review-240 September 14, 2023 09:39 Destroyed
@github-actions github-actions bot temporarily deployed to review-240 September 14, 2023 09:47 Destroyed
@fumimowdan fumimowdan force-pushed the feature/133-notify-mailer branch from e9b94ee to e1449f5 Compare September 14, 2023 10:05
@github-actions github-actions bot temporarily deployed to review-240 September 14, 2023 10:08 Destroyed
Run rails db:seed in review environment when app starts

Updated Dockerfile to use a app startup shell script for that effect
starts one worker instance
@fumimowdan fumimowdan force-pushed the feature/133-notify-mailer branch from e1449f5 to 4ce5ac0 Compare September 14, 2023 10:25
@github-actions github-actions bot temporarily deployed to review-240 September 14, 2023 10:28 Destroyed
This environment variable was used by the old govuk notify client and
is not in use anymore
@github-actions github-actions bot temporarily deployed to review-240 September 14, 2023 10:40 Destroyed
@fumimowdan fumimowdan merged commit 5a92bf8 into main Sep 14, 2023
6 checks passed
@fumimowdan fumimowdan deleted the feature/133-notify-mailer branch September 14, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Deploy review app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants