Fix rubocop offenses

DFE-Digital · Oct 24, 2023 · bc5ac94 · bc5ac94
1 parent 6022987
commit bc5ac94
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/app/controllers/system_admin/applicants_controller.rb b/app/controllers/system_admin/applicants_controller.rb
@@ -66,7 +66,7 @@ def find_applicant
 
     def check_user_roles
       unless current_user.has_role?(:servant)
-        redirect_to(root_path, alert: "You do not have permission to access this page")
+        redirect_to(root_path, alert: t("errors.access_denied"))
       end
     end
   end

diff --git a/app/controllers/system_admin/reports_controller.rb b/app/controllers/system_admin/reports_controller.rb
@@ -21,11 +21,11 @@ def check_user_roles
       case params[:id]
       when "home_office", "standing_data", "payroll"
         unless current_user.has_role?(:manager)
-          redirect_to(root_path, alert: "You do not have permission to access this page")
+          redirect_to(root_path, alert: t("errors.access_denied"))
         end
       when "applications", "qa"
         unless current_user.has_role?(:admin)
-          redirect_to(root_path, alert: "You do not have permission to access this page")
+          redirect_to(root_path, alert: t("errors.access_denied"))
         end
       end
     end

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -48,3 +48,5 @@ en:
       success: 'User was successfully removed.'
   omniauth_callbacks:
     no_account: 'You have not yet an account!'
+  errors:
+    access_denied: 'You do not have permission to access this page'